FTL Captain's Edition 1.308/Inf 1.301b/EL 1.308

[Mr. Mister]

I don't think this would fall under spell checking, so here it is: there still seem to be some wrongly-tagged combat aug blue choices. On a Zoltan space station (event: "...Zoltan commanders can not be reasoned with..."), the Drone Jammer option is tagged as Teleporter Disruptor instead.

EDIT: Seems to happen to more other Zoltan space stations as well.

[abyssion425]

"This beacon lies in close proximity to a considerably well armed pirate station. You will have to stay in their weapon range if you want to {charg} your {FRL} drive... According to the confused, {apprently} drug influenced com chatter you {recieve} the pirates seem quite amused by that."



the imaged typo made me giggle a little.

Edit: got to the flag ship and then the game crashed.

[R4V3-0N]

it suits the drunk/drugged pirates....

[Mr. Mister]

Uhm, one question: what happens if you set a weapon to do negative ion damage?

[dalolorn]

Uhm, one question: what happens if you set a weapon to do negative ion damage?

Probably the same as negative shield piercing or negative power usage - nothing at all.

Still, you're welcome to try. Maybe you'll get something new and interesting.

[Mr. Mister]

...well call me visionary, but I kinda tested and negative ion damage is definitively a thing.

My test was a bit, eh, pathetic (I added ion damage to the Hull Laser MkI drone and went with the Torus), but I could obvserve some effects.

Whenever the hull laser shot at a system I had ionized, the ion countdown would skip ahead a bit, though I'm not sure said skip did decrease the number of revolutions left if it skipped over the top point or not. In any case, it didn't seem to power up the system by one bar.

The most amazing thing, though, is that negative ion damage heals Zoltan shields (at least enemies'). So, apart from making a bomb to make Zoltan B or A even less dependant on shields (probably even removing the system from the ship layout!), this raises the question if it's possible to destroying the enemy Zoltan shield via overflow.

[jep]

I just posted a buttload of spelling/grammar fixes to the events.xml.append file last night (already merged in, thanks!) I just thought I'd share here my method so other people might also take a whack at it. It doesn't get everything, but it helps find a LOT of problems.

First, go to the github page for the file you are checking and choose the Raw view. Copy all of it to the clipboard. Then go to http://www.freeformatter.com/xpath-tester.html and in the input box put

Code: Select all

<xml>(pasted file text)</xml>

In the Xpath expression box enter

Code: Select all

//text/text()

Change the checkbox to No.
Click the Test XPath button.
You should see all the text stripped out. Click the Copy to Clipboard button.

You can now paste this into your favorite spellchecker program and tell it to check it. I actually went with http://www.microspell.com/fixmytypos.html because it produces a list of the typos. You're going to have to go fix them in the original file anyway, so I felt this worked well. I found it easiest to use a plain text editor (I recommend Programmer's Notepad on Windows) because editing them in your repo on github can be very sluggish. Make sure you fix all occurrences of a typo since so many are copy/pasted multiple times. And if you find one, read the whole chunk of text it was in because that probably hasn't been spell-checked and you'll find other things.

Rinse and repeat.

The other tip I have is to just search for all instances of "it's" because I found there were a ton that needed to be "its". Not knocking the author(s), though. I'm just trying to be thorough.

What would really be nice, though, is to have an xml editor that would spell check without being tripped up by the xml. But so far I haven't found a free one.

Happy (typo) hunting.

[ScubaSteve3465]

Cool stuff, how do i use your typo fix version with CE? or do we have to wait for the Dev to update the mod first?

[jep]

I've already submitted my typo fixes and they have been accepted. Without mucking about with github, though, you'll have to wait until Sleeper Service rolls out a new .ftl file (correct me if I'm wrong about who does what on this project).

Otherwise, if you feel comfortable with some moderate mucking, you could just go to github and get the file that I changed and put it in your .ftl file. You'll need to rename the .ftl to .zip, navigate to the data folder and replace events.xml.append with this one:
https://raw.github.com/sleeper-service- ... xml.append

But that's just one file and I hope to get around to more of them. To Sleeper or anyone else heavy into the CE maintenance/dev - what do you think about putting the entire code on github? Basically the root directory would be the top level of the zip, with the audio, data, fonts, etc. being subfolders? The great thing about that is you could just go to github and choose Download Zip to get the latest version of everything, rename the .zip to .ftl and you'll be all set. You could continue to tell people that they can only submit spell checking changes to the repo.

[Sleeper Service]

Actually I'm kind of managing the thing by myself. A lot of people contributed certain stuff though.

While your suggestion would certainly have some advantages, it might also deter people who would prefer a ready to use file. There could still be normal releases for these of course. Personally, I don't feel very comfortable editing things on github and therefore in the browser. I actually did this entire mod on a 10.1-inch netbook. Github display is not very neat on a small screen and doing things online also slow things down. Github also does not feature some stuff that getit has, like advanced find and replace across multiple files, which became quite important lately with the combat augments. So I'd rather go back to offline editing soon, also mentioned in the github announcement:

Announcement 04.12.2013
Wow, events.xml is done, sweet work by jep. So, I'm pretty inexperienced with this whole Github thing. What happens now? Should I take events.xml off? I'd actually like to, cause I really don't like to edit things in the browser. Also, I feel its cool that he submitted his changes immediately as a pull request. I guess this is more efficient, cause this way people don't double correct the same stuff? Maybe everyone could make pull request and the other forks could also be merged for now, even if you haven't completed what you where doing? I feel like like some forks going to be abandon, and I can not pull them if you don't request it. With event's.xml done, the bulk of the work is through, but I still like to go back to work offline on this soon. So maybe there should be a deadline at some point?

So lets say 15. of December ends this spell check round. Please submit you pull requests till then.